Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve claims verification #31

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Improve claims verification #31

merged 1 commit into from
Mar 14, 2019

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented Mar 14, 2019 •
edited
Loading

  • verify bound_claims in all paths
  • verify bound_claims against /userinfo data
  • verify bound_audiences in all paths
  • revise bound_audiences check when using static keys to conform to our docs
  • more tests

Fixes #30

Improve claims verification
6e1318f 
- verify bound_claims in all paths
- verify bound_claims against /userinfo data
- verify bound_audiences in all paths
- revisw bound_audiences check when using static keys to conform to our docs
- more tests
tyrannosaurus-becks
tyrannosaurus-becks approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent! Great code, great test coverage, variable names are clear.

@kalafut kalafut merged commit 86b4467 into master Mar 14, 2019
@kalafut kalafut deleted the improve-claims-checks branch March 14, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briankassouf briankassouf briankassouf approved these changes

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalafut @tyrannosaurus-becks @briankassouf